chia7712 commented on code in PR #19635:
URL: https://github.com/apache/kafka/pull/19635#discussion_r2073937574
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -413,8 +413,6 @@ class KafkaApis(val requestChannel: RequestChannel,
val topicPartition = new TopicPartition(topicName, partition.index())
if (topicName.isEmpty)
Review Comment:
> It's probably better to change the condition to if (topicName.isEmpty &&
topic.topicId().equals(Uuid.ZERO_UUID)).
The default value of `topic.topicId()` is `Uuid.ZERO_UUID, and hence `if
(topicName.isEmpty && topic.topicId().equals(Uuid.ZERO_UUID))` is always true
if request is before v13. Maybe we can try another condition: `if
(topicName.isEmpty && version > 12`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
