chia7712 commented on code in PR #19578:
URL: https://github.com/apache/kafka/pull/19578#discussion_r2071933799
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1306,7 +1306,10 @@ private Map<TopicPartition, Long>
beginningOrEndOffset(Collection<TopicPartition
// and throw timeout exception if it cannot complete in time.
if (timeout.isZero()) {
applicationEventHandler.add(listOffsetsEvent);
- return listOffsetsEvent.emptyResults();
+ // It is used to align with classic consumer.
+ // When the "timeout == 0", the classic consumer will return
an empty map.
+ // Therefore, the AsyncKafkaConsumer needs to be consistent
with it.
+ return new HashMap<>();
Review Comment:
just FYI - KIP-1140 already cover the case of inconsistent behavior of
`offsetsForTimes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
