lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067085137
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -88,8 +88,9 @@ public class CommonClientConfigs {
"If provided, the backoff per host will increase exponentially for
each consecutive connection failure, up to this maximum. After calculating the
backoff increase, 20% random jitter is added to avoid connection storms.";
public static final String RETRIES_CONFIG = "retries";
- public static final String RETRIES_DOC = "Setting a value greater than
zero will cause the client to resend any request that fails with a potentially
transient error." +
- " It is recommended to set the value to either zero or `MAX_VALUE` and
use corresponding timeout parameters to control how long a client should retry
a request.";
+ public static final String RETRIES_DOC = "It is recommended to set the
value to either `MAX_VALUE` or zero, and use corresponding timeout parameters
to control how long a client should retry a request." +
Review Comment:
didn't go as far as saying "recommended is max." (full stop), since here
it's the commons one that truly doesn't define the default even, so I guess it
could depend on the usage (in practice it's admin and producer, and they do
effectively max it out by default)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
