junrao commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064901409
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -147,7 +158,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_4_0_IV3;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_4_0_IV3; //
when do we update this to `IBP_4_1_IV2`+
Review Comment:
Should we remove this comment?
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -117,6 +117,9 @@ public enum MetadataVersion {
// Enables share groups. Note, share groups are for preview only in 4.1.
(KIP-932).
IBP_4_1_IV1(27, "4.1", "IV1", false),
+ // Enables "streams" groups. Note, streams groups are for early access
only in 4.1. (KIP-1071).
Review Comment:
@AndrewJSchofield : Added a clarification in
https://github.com/apache/kafka/pull/19293/files#r2064970001 regarding
IBP_4_1_IV1. We could follow up there.
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -127,7 +127,15 @@ public enum MetadataVersion {
// *** SHARE GROUPS BECOME PRODUCTION-READY IN THE FUTURE. ITS DEFINITION
ALLOWS A SHARE ***
// *** GROUPS FEATURE TO BE DEFINED IN 4.1 BUT TURNED OFF BY DEFAULT, ABLE
TO BE TURNED ON ***
// *** DYNAMICALLY TO TRY OUT THE PREVIEW CAPABILITY.
***
- IBP_4_2_IV0(28, "4.2", "IV0", false);
+ IBP_4_2_IV0(28, "4.2", "IV0", false),
+
+ // Enables "streams" groups by default for new clusters (KIP-1071).
+ //
+ // *** THIS IS A PLACEHOLDER UNSTABLE VERSION WHICH IS USED TO DEFINE THE
POINT AT WHICH ***
+ // *** STREAMS GROUPS BECOME PRODUCTION-READY IN THE FUTURE. ITS
DEFINITION ALLOWS A STREAMS ***
+ // *** GROUPS FEATURE TO BE DEFINED IN 4.1 BUT TURNED OFF BY DEFAULT, ABLE
TO BE TURNED ON ***
+ // *** DYNAMICALLY TO TRY OUT THE EARLY ACCESS CAPABILITY.
***
+ IBP_4_2_IV1(29, "4.2", "IV1", false);
Review Comment:
It's a bit awkward to add an unstable MV for each unstable feature level.
Could we introduce a single unstable MV that's shared between Qfk and streams
MV?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
