ableegoldman commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2059384302
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1805,12 +1816,12 @@ private void completeShutdown(final boolean cleanRun) {
log.error("Failed to unsubscribe due to the following error: ", e);
}
try {
- mainConsumer.close();
+ mainConsumer.close(closeOptions);
} catch (final Throwable e) {
log.error("Failed to close consumer due to the following error:",
e);
}
try {
- restoreConsumer.close();
+ restoreConsumer.close(closeOptions);
Review Comment:
Hm actually how could it even send a LeaveGroup if LEAVE_GROUP is selected
for a consumer that isn't part of a group? That is, by definition the
coordinator is unknown, so where would the request even be sent?
Don't remember of the top of my head how we handled this in the consumer
client CloseOptions PR but it seems like the consumer should be agnostic to the
GroupMembershipOperation and never send anything if it's not part of a group to
begin with, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
