chia7712 commented on code in PR #19529:
URL: https://github.com/apache/kafka/pull/19529#discussion_r2057772071
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeLocalMetadataStore.java:
##########
@@ -112,7 +112,7 @@ public static List<AclBinding> aclBindings(String
aclPrinciple) {
* @param aclBinding {@link AclBinding}
*/
public static void addACLs(String principal, AclBinding aclBinding) {
- Vector<AclBinding> aclBindings =
FakeLocalMetadataStore.ALL_ACLS.getOrDefault(principal, new Vector<>());
+ List<AclBinding> aclBindings =
FakeLocalMetadataStore.ALL_ACLS.getOrDefault(principal, new ArrayList<>());
Review Comment:
that is interesting. It seems those methods should be thread-safe, but it
isn't. Could you please revert those changes and then open a jira for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
