AndrewJSchofield commented on code in PR #19536:
URL: https://github.com/apache/kafka/pull/19536#discussion_r2056803791
##########
clients/src/main/resources/common/message/ShareFetchResponse.json:
##########
@@ -67,7 +67,7 @@
{ "name": "LeaderEpoch", "type": "int32", "versions": "0+",
"about": "The latest known leader epoch." }
]},
- { "name": "Records", "type": "records", "versions": "0+",
"nullableVersions": "0+", "about": "The record data." },
+ { "name": "Records", "type": "records", "versions": "0+", "about":
"The record data." },
Review Comment:
Well, yes, unless we are looking to have the JSON file document what was
previously there too for v0. Otherwise, we could entirely remove all mention of
v0, which we did not do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
