jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054506081
##########
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##########
@@ -250,6 +251,26 @@ public Optional<VoterSet> updateVoter(VoterNode voter) {
return Optional.empty();
}
+ /**
+ * Update a voter by only comparing the node id.
+ *
+ * This update voter operation doesn't compare the directory id. This is
useful when upgrading
+ * from a voter set that doesn't support directory id to one that supports
directory ids.
Review Comment:
Yes. After the kraft version has been upgraded to 1, if the directory id
changes, the user will have to remove the voter with the old id and then add
the voter with the new directory id.
This is done to make sure that the partition stays consistent after there is
a disk failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
