chia7712 commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2050092192
##########
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##########
@@ -182,6 +186,7 @@ public void testDowngradeWithReleaseVersion(ClusterInstance
cluster) {
"kraft.version was downgraded to 0.\n" +
"metadata.version was downgraded to 18.\n" +
"share.version was downgraded to 0.\n" +
+ "streams.group.version was downgraded to 0.\n" +
Review Comment:
Out of curiosity, have you consider using "streams.version" instead?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -63,7 +63,8 @@ public class GroupCoordinatorConfig {
"The " + Group.GroupType.SHARE + " and " + Group.GroupType.STREAMS
+ " rebalance protocols are in early access and therefore must not be used in
production.";
public static final List<String>
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT = List.of(
Group.GroupType.CLASSIC.toString(),
- Group.GroupType.CONSUMER.toString());
+ Group.GroupType.CONSUMER.toString(),
+ Group.GroupType.STREAMS.toString());
Review Comment:
If this streams feature is added by default, should we remove the following
warnings?
```java
if (protocols.contains(GroupType.STREAMS)) {
warn(s"Streams groups and the new '${GroupType.STREAMS}' rebalance
protocol are enabled. " +
"This is part of the early access of KIP-1071 and MUST NOT be used
in production.")
}
```
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaConfig.scala#L386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
