lucasbru commented on code in PR #19491:
URL: https://github.com/apache/kafka/pull/19491#discussion_r2047774189
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -237,6 +237,7 @@ private static
List<StreamsGroupHeartbeatRequestData.TopicInfo> getRepartitionTo
repartitionTopicInfo.topicConfigs().add(new
StreamsGroupHeartbeatRequestData.KeyValue().setKey(k).setValue(v))
);
repartitionTopicsInfo.add(repartitionTopicInfo);
+
repartitionTopicInfo.topicConfigs().sort(Comparator.comparing(StreamsGroupHeartbeatRequestData.KeyValue::key).thenComparing(StreamsGroupHeartbeatRequestData.KeyValue::value));
Review Comment:
You are right, since this is built from a map, we don't really need it
unless the code somehow changes. removed.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -251,6 +252,7 @@ private static
List<StreamsGroupHeartbeatRequestData.TopicInfo> getChangelogTopi
changelogTopic.getValue().topicConfigs().forEach((k, v) ->
changelogTopicInfo.topicConfigs().add(new
StreamsGroupHeartbeatRequestData.KeyValue().setKey(k).setValue(v))
);
+
changelogTopicInfo.topicConfigs().sort(Comparator.comparing(StreamsGroupHeartbeatRequestData.KeyValue::key).thenComparing(StreamsGroupHeartbeatRequestData.KeyValue::value));
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
