LoganZhuZzz commented on code in PR #19465:
URL: https://github.com/apache/kafka/pull/19465#discussion_r2046653795
##########
core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala:
##########
@@ -705,18 +695,7 @@ final class KafkaMetadataLogTest {
val leaderEpoch = 5
val maxBatchSizeInBytes = 16384
val recordSize = 64
- val config = new MetadataLogConfig(
- DefaultMetadataLogConfig.logSegmentBytes,
- DefaultMetadataLogConfig.logSegmentMinBytes,
- DefaultMetadataLogConfig.logSegmentMillis,
- DefaultMetadataLogConfig.retentionMaxBytes,
- DefaultMetadataLogConfig.retentionMillis,
- maxBatchSizeInBytes,
- DefaultMetadataLogConfig.maxFetchSizeInBytes,
- DefaultMetadataLogConfig.deleteDelayMillis,
- DefaultMetadataLogConfig.nodeId
- )
- val log = buildMetadataLog(tempDir, mockTime, config)
+ val log = buildMetadataLog(tempDir, mockTime, DefaultMetadataLogConfig)
Review Comment:
I’ve updated it to use the correct value, and the test now passes as
expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
