AndrewJSchofield commented on code in PR #19293:
URL: https://github.com/apache/kafka/pull/19293#discussion_r2038119258
##########
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala:
##########
@@ -85,6 +85,9 @@ abstract class AbstractApiVersionsRequestTest(cluster:
ClusterInstance) {
assertEquals(0,
apiVersionsResponse.data().supportedFeatures().find(EligibleLeaderReplicasVersion.FEATURE_NAME).minVersion())
assertEquals(EligibleLeaderReplicasVersion.ELRV_1.featureLevel(),
apiVersionsResponse.data().supportedFeatures().find(EligibleLeaderReplicasVersion.FEATURE_NAME).maxVersion())
+
+ assertEquals(0,
apiVersionsResponse.data().supportedFeatures().find(ShareVersion.FEATURE_NAME).minVersion())
+ assertEquals(ShareVersion.SV_1.featureLevel(),
apiVersionsResponse.data().supportedFeatures().find(ShareVersion.FEATURE_NAME).maxVersion())
Review Comment:
The aim here is that `unstable.feature.versions.enable=true` should not be
required to enable share groups in AK 4.1. They should be disabled on new
brokers by default, but possible to enable using `kafka-features.sh upgrade`.
I'm trying to do what was done for the ELR preview
(https://github.com/apache/kafka/pull/17867 and then
https://github.com/apache/kafka/pull/18954).
In AK 4.2, the metadata version will be `IBP_4_2_IV0`, so a new broker
should get `share.version=1` by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
