lucasbru commented on code in PR #19421:
URL: https://github.com/apache/kafka/pull/19421#discussion_r2037149394
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsRebalanceListener.java:
##########
@@ -22,7 +22,7 @@
/**
* Callbacks for handling Streams group rebalance events in Kafka Streams.
Review Comment:
maybe replace callback by listener in the comment as well?
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##########
@@ -120,6 +120,8 @@ SmokeTestDriver.VerificationResult result() {
"true, false, true",
"false, false, false",
"true, false, false",
+ "true, true, true",
Review Comment:
Are the proccessing thread test combinations stable now?
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1108,7 +1090,20 @@ private void subscribeConsumer() {
if (topologyMetadata.usesPatternSubscription()) {
mainConsumer.subscribe(topologyMetadata.sourceTopicPattern(),
rebalanceListener);
Review Comment:
Should we throw an error here that pattern subscriptions are not supported?
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1476,17 +1473,12 @@ private ConsumerRecords<byte[], byte[]>
pollRequests(final Duration pollTime) {
return records;
}
- public void maybeHandleAssignmentFromStreamsRebalanceProtocol() {
+ public void maybeHandleStreamsRebalanceProtocol() {
Review Comment:
Can we find a better name for this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
