FrankYang0529 commented on code in PR #19409: URL: https://github.com/apache/kafka/pull/19409#discussion_r2033540925
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -194,16 +193,9 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) private val _quorumConfig = new QuorumConfig(this) def quorumConfig: QuorumConfig = _quorumConfig - private val _groupCoordinatorConfig = new GroupCoordinatorConfig(this) Review Comment: Hi @dajac, thanks for the comment. I tried to migrate `KafkaConfig` out of core module. My first idea is that moving some non-dynamic config out of it. However, this approach doesn't work, because some config like `GroupCoordinatorConfig` does validation in constructor. If moving it out of `KafkaConfig`, we cannot validate config when starting the server. Another idea is to add `groupCoordinatorConfig` function to `AbstractKafkaConfig`. I didn't try this first, because I wonder whether we can split `KafkaConfig` to small classes. I will close this PR and do more survey. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
