Parkerhiphop commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2031557837
########## core/src/main/scala/kafka/network/SocketServer.scala: ########## @@ -495,8 +491,7 @@ private[kafka] abstract class Acceptor(val socketServer: SocketServer, val shouldRun = new AtomicBoolean(true) - def metricPrefix(): String - def threadPrefix(): String + def threadPrefix(): String = DataPlaneAcceptor.ThreadPrefix Review Comment: Agreed. I was focused on fixing the previous test case and missed this—thanks for the suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
