TaiJuWu commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2027851052
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -441,7 +441,6 @@ public RemoteLogMetadataManager
createRemoteLogMetadataManager() {
@Test
void testStartup() {
- remoteLogManager.startup();
Review Comment:
I just rename to `testConfigure` to reflect the usage of test configuration.
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -3011,7 +2996,6 @@ public RemoteLogMetadataManager
createRemoteLogMetadataManager() {
task.cleanupExpiredRemoteLogSegments();
- verifyNoMoreInteractions(remoteStorageManager);
Review Comment:
Done.
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -3785,4 +3807,20 @@ private void appendRLMConfig(Properties props) {
props.put(DEFAULT_REMOTE_LOG_METADATA_MANAGER_CONFIG_PREFIX +
remoteLogMetadataProducerTestProp, remoteLogMetadataProducerTestVal);
}
+ public static class MonitorableNoOpRemoteStorageManager extends
NoOpRemoteStorageManager implements Monitorable {
+ public boolean pluginMetrics = false;
+
+ @Override
+ public void withPluginMetrics(PluginMetrics metrics) {
+ pluginMetrics = true;
+ }
+ }
+
+ public static class MonitorableNoOpRemoteLogMetadataManager extends
NoOpRemoteLogMetadataManager implements Monitorable {
+ public boolean pluginMetrics = false;
+ @Override
Review Comment:
Fix, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
