ijuma commented on code in PR #19250:
URL: https://github.com/apache/kafka/pull/19250#discussion_r2004798260
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -636,8 +632,6 @@ private TransactionManager
configureTransactionState(ProducerConfig config,
* initialized, this method should no longer be used.
*
* @throws IllegalStateException if no {@code transactional.id} has been
configured
- * @throws org.apache.kafka.common.errors.UnsupportedVersionException
fatal error indicating the broker
Review Comment:
@jolshan Thoughts on this and similar changes? Two other options:
1. Keep `UnsupportedVersionException` with a generic message (instead of the
specific "does not support transactions").
2. Keep `UnsupportedVersionException` with a different specific message.
Perhaps alternative `1` is the right approach if we expect to evolve things
such that passing certain parameters may result in
`UnsupportedVersionException`. Similar to `sendOffsetsToTransaction` with all
consumer group metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
