chia7712 commented on code in PR #19031:
URL: https://github.com/apache/kafka/pull/19031#discussion_r2004316995
##########
.github/actions/run-gradle/action.yml:
##########
@@ -96,9 +99,11 @@ runs:
-Pkafka.test.xml.output.dir=$TEST_XML_OUTPUT_DIR \
-Pkafka.cluster.test.repeat=$TEST_REPEAT \
-Pkafka.test.verbose=$TEST_VERBOSE \
+ -PheapDumpPath=$HEAP_DUMP_DIR \
-PcommitId=xxxxxxxxxxxxxxxx \
$TEST_TASK
exitcode="$?"
+ find heap-dumps
Review Comment:
Is it used to debug? if so, maybe using `ls` can offer more useful output?
##########
.github/actions/run-gradle/action.yml:
##########
@@ -86,7 +86,10 @@ runs:
run: |
set +e
./.github/scripts/thread-dump.sh &
- timeout ${TIMEOUT_MINUTES}m ./gradlew --build-cache --continue
--no-scan \
+ mkdir -p heap-dumps
+ HEAP_DUMP_DIR=$(readlink -f heap-dumps)
+ timeout ${TIMEOUT_MINUTES}m ./gradlew --continue --no-scan \
+ -Dorg.gradle.jvmargs="-Xmx4g -Xss4m -XX:+UseParallelGC
-XX:+ExitOnOutOfMemoryError -XX:+HeapDumpOnOutOfMemoryError
-XX:HeapDumpPath=$HEAP_DUMP_DIR" \
Review Comment:
maybe we can add comment to `gradle.properties` to remind us to keep the
memory configs consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
