[
https://issues.apache.org/jira/browse/KAFKA-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936878#comment-17936878
]
Mickael Maison commented on KAFKA-18792:
----------------------------------------
Would it be worth to also do some validations for commits with co-authors?
The "Co-authored-by:" have some pretty strick formatting requirements for
GitHub to properly recognize the authors. For example, the commit body must not
include new lines after any "Co-authored-by: " line, there also cannot be
newlines between each "Co-authored-by:" line, etc
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line
> Enforce uniform PR structure for merge queue
> --------------------------------------------
>
> Key: KAFKA-18792
> URL: https://issues.apache.org/jira/browse/KAFKA-18792
> Project: Kafka
> Issue Type: Sub-task
> Components: build
> Reporter: David Arthur
> Priority: Major
>
> Since the merge queue will use the repo's default commit message, we cannot
> customize the commit when adding to the queue. Instead, we will use the PR
> title and body as the commit message and subject (KAFKA-18791).
>
> In order to ensure well-formed commits, we will need a GitHub Action to
> validate the PR title and PR body.
>
> Specifically, we should have the following checks:
> * PR title includes KAFKA-XXXXX, MINOR, or HOTFIX
> * PR title is less than 120 characters
> * PR title is not automatically truncated by GitHub (ending in ...)
> * PR body includes "Reviewers:" line
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
