cmccabe commented on code in PR #19205:
URL: https://github.com/apache/kafka/pull/19205#discussion_r1994095172
##########
metadata/src/main/java/org/apache/kafka/image/FeaturesDelta.java:
##########
@@ -66,6 +66,10 @@ public void replay(FeatureLevelRecord record) {
+ "please ensure the metadata version is set to " +
MetadataVersion.MINIMUM_VERSION + " (or higher) before "
+ "updating the software version. The metadata version
can be updated via the `kafka-features` command-line tool.", e);
}
+ } else if (record.name().equals(KRaftVersion.FEATURE_NAME)) {
+ // Skip any feature level record for kraft.version. This has two
benefits:
+ // 1. It removes from snapshots any FeatureLevelRecord for
kraft.version that was incorrectly written to the log
+ // 2. Allows ApiVersions to report the correct finalized
kraft.version
Review Comment:
can you add a reference to this JIRA in this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
