ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r1993566454
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##########
@@ -326,12 +328,10 @@ public void testCommitSync() {
networkClientDelegate.poll(time.timer(0));
assertTrue(shareConsumeRequestManager.hasCompletedFetches());
- Acknowledgements acknowledgements = Acknowledgements.empty();
- acknowledgements.add(1L, AcknowledgeType.ACCEPT);
- acknowledgements.add(2L, AcknowledgeType.ACCEPT);
- acknowledgements.add(3L, AcknowledgeType.REJECT);
+ Acknowledgements acknowledgements = getAcknowledgements(1, 3);
Review Comment:
Yes, I have updated the code now to have a mix of AcknowledgeTypes, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
