lucasbru commented on code in PR #19088:
URL: https://github.com/apache/kafka/pull/19088#discussion_r1979479030
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4308,9 +4308,18 @@ public void replay(
String groupId = key.groupId();
String regex = key.regularExpression();
+ ConsumerGroup consumerGroup;
+ try {
+ consumerGroup = getOrMaybeCreatePersistedConsumerGroup(groupId,
value != null);
+ } catch (GroupIdNotFoundException ex) {
+ // If the group does not exist and a tombstone is replayed, we can
ignore it.
Review Comment:
This is a bit subtle. I suppose we will never throw the exception is `value
!= null`, so we know that a tombstone is replayed if we enter the `catch`
block. Making this explicit in the comment would have helped me, but I'm fine
with leaving it like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
