cadonna commented on code in PR #19089:
URL: https://github.com/apache/kafka/pull/19089#discussion_r1979473224
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -448,8 +448,12 @@ private <VR> KTable<K, VR> doTransformValues(final
ValueTransformerWithKeySuppli
valueSerde = materializedInternal.valueSerde();
queryableStoreName = materializedInternal.queryableStoreName();
// only materialize if materialized is specified and it has
queryable name
- final StoreFactory storeFactory = queryableStoreName != null ?
(new KeyValueStoreMaterializer<>(materializedInternal)) : null;
- storeBuilder = Collections.singleton(new
FactoryWrappingStoreBuilder<>(storeFactory));
+ if (queryableStoreName != null) {
+ final StoreFactory storeFactory = new
KeyValueStoreMaterializer<>(materializedInternal);
+ storeBuilder = Collections.singleton(new
FactoryWrappingStoreBuilder<>(storeFactory));
+ } else {
+ storeBuilder = null;
Review Comment:
Is it possible to have a test that verifies that materialization does not
happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
