squah-confluent commented on code in PR #18934:
URL: https://github.com/apache/kafka/pull/18934#discussion_r1958519491
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeMetrics.java:
##########
@@ -71,7 +71,7 @@ public interface CoordinatorRuntimeMetrics extends
AutoCloseable {
* Record the thread idle time.
* @param idleTimeMs The idle time in milliseconds.
*/
- void recordThreadIdleTime(long idleTimeMs);
+ void recordThreadIdleTime(double idleTimeMs);
Review Comment:
It looks a bit strange to have this particular metric accept a double while
all the other metrics accept a long.
But I don't think we should change the other metrics to accept doubles,
since they're strictly durations. This one is a little different and normalized
by the number of threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
