chia7712 commented on code in PR #18894:
URL: https://github.com/apache/kafka/pull/18894#discussion_r1956203598
##########
tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommand.java:
##########
@@ -250,7 +252,7 @@ TreeMap<String, Entry<ShareGroupDescription,
Collection<SharePartitionOffsetInfo
groupId,
tp.getKey().topic(),
tp.getKey().partition(),
- earliestResult.get(tp.getKey())
+
Optional.ofNullable(earliestResult.get(tp.getKey()))
Review Comment:
@AndrewJSchofield thanks for the sharing.
> but I went with consistency. It's modelled on
ListConsumerGroupOffsetsResult
fair enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
