mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1943854473
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNode.java:
##########
@@ -103,13 +103,16 @@ public void writeToTopology(final InternalTopologyBuilder
topologyBuilder) {
consumedInternal().valueDeserializer(),
topicName);
- processorParameters.addProcessorTo(topologyBuilder, new String[]
{sourceName});
+ processorParameters.addProcessorTo(topologyBuilder, sourceName);
// if the KTableSource should not be materialized, stores will be
null or empty
final KTableSource<K, V> tableSource = (KTableSource<K, V>)
processorParameters.processorSupplier();
if (tableSource.stores() != null) {
if (shouldReuseSourceTopicForChangelog) {
+ // TODO: rewrite this part to use
Topology.addReadOnlyStateStore() instead
+ // should allow to move off using
`InternalTopologyBuilder` in favor of the public `Topology` API
tableSource.stores().forEach(store -> {
+ // connect source topic as (read-only) changelog topic
for fault-tolerance
Review Comment:
```suggestion
// connect the source topic as (read-only) changelog
topic for fault-tolerance
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
