mjsax commented on code in PR #18780:
URL: https://github.com/apache/kafka/pull/18780#discussion_r1938590264
##########
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##########
@@ -2257,16 +2257,16 @@ private Topology topologyWithStaticTopicName() {
private TopologyDescription.Source addSource(final String sourceName,
final String... sourceTopic) {
- topology.addSource((Topology.AutoOffsetReset) null, sourceName, null,
null, null, sourceTopic);
- final StringBuilder allSourceTopics = new
StringBuilder(sourceTopic[0]);
- for (int i = 1; i < sourceTopic.length; ++i) {
- allSourceTopics.append(", ").append(sourceTopic[i]);
- }
+ topology.addSource((AutoOffsetReset) null, sourceName, null, null,
null, sourceTopic);
Review Comment:
While cleaning up the code, I found that we cast to the "old"
`Topology.AutoOffsetReset` enum here. Changing it to use the new
`AutoOffsetReset` class, `TopologyTest` broke exposing the bug.
Everything else in this class is just side-cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
