mjsax commented on code in PR #18734:
URL: https://github.com/apache/kafka/pull/18734#discussion_r1938119091
##########
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java:
##########
@@ -79,12 +79,12 @@ private SessionWindows(final long gapMs, final long
graceMs) {
this.gapMs = gapMs;
this.graceMs = graceMs;
- if (gapMs <= 0) {
- throw new IllegalArgumentException("Gap time cannot be zero or
negative.");
+ if (gapMs < 0) {
+ throw new IllegalArgumentException("Gap time cannot be negative.");
Review Comment:
JavaDocs. Good catch!
Did briefly look into docs. Did not found anything that we would need to
update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
