AndrewJSchofield commented on code in PR #18743:
URL: https://github.com/apache/kafka/pull/18743#discussion_r1935362208
##########
core/src/main/java/kafka/server/share/ShareCoordinatorMetadataCacheHelperImpl.java:
##########
@@ -99,14 +99,19 @@ public Node getShareCoordinator(SharePartitionKey key,
String internalTopicName)
}
}
}
- } catch (CoordinatorNotAvailableException e) {
- log.warn("Coordinator not available", e);
+ } catch (Exception e) {
+ log.warn("Exception while getting share coordinator", e);
}
return Node.noNode();
}
@Override
public List<Node> getClusterNodes() {
- return
CollectionConverters.asJava(metadataCache.getAliveBrokerNodes(interBrokerListenerName).toSeq());
+ try {
+ return
CollectionConverters.asJava(metadataCache.getAliveBrokerNodes(interBrokerListenerName).toSeq());
+ } catch (Exception e) {
+ log.warn("Exception while getting cluste nodes", e);
Review Comment:
nit: "cluste" is not a word :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
