mjsax commented on code in PR #18722:
URL: https://github.com/apache/kafka/pull/18722#discussion_r1931471690
##########
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##########
@@ -3062,7 +3062,7 @@ <GK, GV, RV> KStream<K, RV> leftJoin(final
GlobalKTable<GK, GV> globalTable,
* @see #map(KeyValueMapper)
*/
<KOut, VOut> KStream<KOut, VOut> process(
- final ProcessorSupplier<? super K, ? super V, KOut, VOut>
processorSupplier,
+ final ProcessorSupplier<? super K, ? super V, ? extends KOut, ?
extends VOut> processorSupplier,
Review Comment:
While this is technically public API, to me it's a bug-fix, so would not
want to do a KIP for it... Similar to KTable interface changes. -- On the other
hand, it more than a one-liner... Overall not sure...
We did a KIP back in the days:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-100+-+Relax+Type+constraints+in+Kafka+Streams+API
Note, that some interfaces actually do use `? super/extend X` even if the
original KIP adding the methods does _not_ say so... So we did diverge from it
effectively already.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
