jolshan commented on code in PR #18604:
URL: https://github.com/apache/kafka/pull/18604#discussion_r1925643328
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1052,7 +1057,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private def batchMissingRequiredVerification(batch: MutableRecordBatch,
requestVerificationGuard: VerificationGuard): Boolean = {
-
producerStateManager.producerStateManagerConfig().transactionVerificationEnabled()
&& !batch.isControlBatch &&
+
producerStateManager.producerStateManagerConfig().transactionVerificationEnabled()
&&
Review Comment:
I think the original reason to have the method was to not have too many if
conditions on that line. Not sure if it would be useful to have one big method
that explains why the checks are ordered in such a way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
