chia7712 commented on code in PR #18602:
URL: https://github.com/apache/kafka/pull/18602#discussion_r1923894424
##########
build.gradle:
##########
@@ -1102,8 +1103,9 @@ project(':core') {
testImplementation project(':server-common').sourceSets.test.output
testImplementation project(':storage:storage-api').sourceSets.test.output
testImplementation project(':server').sourceSets.test.output
- testImplementation project(':test-common')
- testImplementation project(':test-common:test-common-api')
+ testImplementation project(':test-common:test-common-runtime')
+ testImplementation project(':test-common:test-common-internal-api')
+ testImplementation project(':test-common:test-common-util')
Review Comment:
> Since test-common-internal-api is meant to be the abstraction for the test
infrastructure offered by test-common-runtime, it doesn't make sense to include
one without the other. It might be confusing for developers if @ClusterTest was
available to import, but was not actually usable.
Yes, you're right. Let's keep the current structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
