kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1903351456
########## raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java: ########## @@ -17,9 +17,11 @@ package org.apache.kafka.raft; import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.metrics.Metrics; Review Comment: Adding unit tests here would require us to expose the `kafkaRaftMetrics` object we pass in. After adding the `KafkaRaftClientReconfigTest#testLeaderMetricsAreReset` as well as `KafkaMetricsTest#testLeaderMetrics`, I can't think of any additional cases that are not covered in either that need to be covered here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
