TaiJuWu commented on code in PR #18358:
URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -593,6 +593,9 @@ def close_port(self, listener_name):
def start_minikdc_if_necessary(self, add_principals=""):
has_sasl = self.security_config.has_sasl
+ # Since KafkaService is utilized by both controller and broker, we do
not set miniKDC to None.
+ # This avoids the creation of an additional miniKDC, which could
result in a mismatch
+ # between client and server tokens if two miniKDC instances are
running concurrently.
if has_sasl:
Review Comment:
This depend on `KafkaService` config.
When controller or broker is created, it will check their configs and decide
to wherther utilize SASL.
That means we will check both config of brokers and controllers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
