mingyen066 commented on code in PR #17488:
URL: https://github.com/apache/kafka/pull/17488#discussion_r1859137211
##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStoreTest.java:
##########
@@ -94,8 +93,8 @@ public void
testFlushFailureWhenWriteToSecondaryStoreFailsForTombstoneOffsets()
AtomicReference<Throwable> callbackError = new AtomicReference<>();
Future<Void> setFuture =
offsetBackingStore.set(getSerialisedOffsets(mkMap(
- mkEntry(OFFSET_KEY_SERIALIZED, null),
Review Comment:
Since there are still many tests using mkEntry to create entries with null
values, this PR will migrate all the code that can be converted to use
Map.entry. The remaining code that still uses mkEntry will only for creating
null entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
