ableegoldman commented on code in PR #17892:
URL: https://github.com/apache/kafka/pull/17892#discussion_r1853102962
##########
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##########
@@ -68,13 +72,23 @@
* Streams configs that apply at the topology level. The values in the {@link
StreamsConfig} parameter of the
* {@link org.apache.kafka.streams.KafkaStreams} constructor or the {@link
KafkaStreamsNamedTopologyWrapper} constructor (deprecated)
* will determine the defaults, which can then be overridden for specific
topologies by passing them in when creating the
- * topology builders via the {@link
org.apache.kafka.streams.StreamsBuilder#StreamsBuilder(TopologyConfig)
StreamsBuilder(TopologyConfig)} method.
+ * topology builders via the {@link
org.apache.kafka.streams.StreamsBuilder#StreamsBuilder(TopologyConfig)
StreamsBuilder(TopologyConfig)} method
+ * for DSL applications, or when creating a PAPI topology via the {@link
Topology#Topology(TopologyConfig)} constructor.
+ * <p>
+ * Note that some configs that are only defined in the TopologyConfig and not
in the StreamsConfig, such as the {@code processor.wrapper.class},
Review Comment:
ah, good catch -- this comment is actually out of date, and I did end up
having to add the config to StreamsConfig as well.
I definitely share your concerns about people forgetting to properly pipe
things in to the Topology/StreamsBuilder through TopologyConfig though. I
recently filed [KAFKA-18053](https://issues.apache.org/jira/browse/KAFKA-18053)
for exactly this problem, with one subtask covering a way to improve the
situation without a KIP by detecting and notifying users of a misconfiguration.
Ideally we can include this fix in 4.0 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
