TaiJuWu commented on code in PR #17771:
URL: https://github.com/apache/kafka/pull/17771#discussion_r1848500117
##########
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##########
@@ -138,6 +139,36 @@ public void
testNullStatusOnKraftCommandAlterClientMetrics() {
assertEquals("Completed updating config for client-metric cm.",
message);
}
+ @ClusterTest
+ public void testAddConfigKeyValuesUsingCommand() throws Exception {
+
+ try (Admin client = cluster.admin()) {
+ NewTopic newTopic = new NewTopic("test-topic", 1, (short) 1);
+ client.createTopics(Collections.singleton(newTopic)).all().get();
+ }
+
Review Comment:
We need to make sure topic is created here.
You can use
https://github.com/apache/kafka/blob/53d8316b5da7d8355331aa2d50193748c8261706/test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/ClusterInstance.java#L250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
