apoorvmittal10 commented on code in PR #17772:
URL: https://github.com/apache/kafka/pull/17772#discussion_r1837744865
##########
share/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java:
##########
@@ -211,7 +228,8 @@ private ReadShareGroupStateResult readResponsesToResult(
int partition = partitionFuture.getKey();
CompletableFuture<ReadShareGroupStateResponse> future
= partitionFuture.getValue();
try {
- ReadShareGroupStateResponse partitionResponse =
future.get();
+ // already completed because of allOf call in the
caller
+ ReadShareGroupStateResponse partitionResponse =
future.get(0, TimeUnit.MILLISECONDS);
Review Comment:
Why not to combine future and call thenApply? Isn't thenApply will be
triggered when all futures are completed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
