lucasbru commented on code in PR #17433:
URL: https://github.com/apache/kafka/pull/17433#discussion_r1820813476
##########
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##########
@@ -159,8 +192,8 @@ class DefaultAutoTopicCreationManager(
}
private def sendCreateTopicRequest(
- creatableTopics: Map[String, CreatableTopic],
- metadataRequestContext: Option[RequestContext]
+ creatableTopics: Map[String,
CreatableTopic],
+ requestContext: Option[RequestContext]
Review Comment:
Done
##########
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##########
@@ -108,6 +115,32 @@ class DefaultAutoTopicCreationManager(
uncreatableTopicResponses ++ creatableTopicResponses
}
+ override def createStreamsInternalTopics(
+ topics: Map[String, CreatableTopic],
+ requestContext: RequestContext
+ ): Unit = {
+
+ // Set default values for numPartitions and replicationFactor if they are
not provided
Review Comment:
Assuming you mean the inline comment. Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
