apoorvmittal10 commented on code in PR #17583:
URL: https://github.com/apache/kafka/pull/17583#discussion_r1817027095
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1807,16 +1807,15 @@ &&
checkForStartOffsetWithinBatch(inFlightBatch.firstOffset(), inFlightBatch.las
// Even if write share group state RPC call fails, we will
still go ahead with the state transition.
// Update the cached state and start and end offsets after
releasing the acquisition lock on timeout.
maybeUpdateCachedStateAndOffsets();
-
- // If we have an acquisition lock timeout for a
share-partition, then we should check if
- // there is a pending share fetch request for the
share-partition and complete it.
- DelayedShareFetchKey delayedShareFetchKey = new
DelayedShareFetchGroupKey(groupId, topicIdPartition.topicId(),
topicIdPartition.partition());
-
replicaManager.completeDelayedShareFetchRequest(delayedShareFetchKey);
});
}
} finally {
lock.writeLock().unlock();
}
+ // If we have an acquisition lock timeout for a share-partition, then
we should check if
+ // there is a pending share fetch request for the share-partition and
complete it.
+ DelayedShareFetchKey delayedShareFetchKey = new
DelayedShareFetchGroupKey(groupId, topicIdPartition.topicId(),
topicIdPartition.partition());
Review Comment:
My bad, corrected it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
