chia7712 commented on code in PR #17584:
URL: https://github.com/apache/kafka/pull/17584#discussion_r1813419731
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -925,7 +925,7 @@ public Map<TopicPartition, OffsetAndMetadata>
fetchCommittedOffsets(final Set<To
final Generation generationForOffsetRequest = generationIfStable();
if (pendingCommittedOffsetRequest != null &&
- !pendingCommittedOffsetRequest.sameRequest(partitions,
generationForOffsetRequest)) {
+ !pendingCommittedOffsetRequest.sameOrSubsetRequest(partitions,
generationForOffsetRequest)) {
Review Comment:
If we allow reusing the previous commit when matching subsets, the returned
`Map<TopicPartition, OffsetAndMetadata>` will contain unrelated topic
partitions. Therefore, should we adjust the return map of `consumer#committed`
to match the input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
