mjsax commented on code in PR #17190:
URL: https://github.com/apache/kafka/pull/17190#discussion_r1803800476
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -1776,27 +1229,6 @@ public void process(final Record<String, String> record)
{
}
}
- @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
Review Comment:
Seems we should not remove this (it's not `@Deprecated`) and comment says
`Need to be migrated`, but rather rewrite to for the new processor API? Or is
it unused now?
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -312,79 +312,6 @@ public void
testDrivingSimpleTopologyWithDroppingPartitioner() {
assertTrue(outputTopic1.isEmpty());
}
- @Test
- public void testDrivingStatefulTopology() {
Review Comment:
Why are we removing this test? Seems we should keep it. It's not marked as
`@Deprecated` and does not say "old API" in it's name either, nor is their a
comment that it would test old API.
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -312,79 +312,6 @@ public void
testDrivingSimpleTopologyWithDroppingPartitioner() {
assertTrue(outputTopic1.isEmpty());
}
- @Test
- public void testDrivingStatefulTopology() {
- final String storeName = "entries";
- driver = new TopologyTestDriver(createStatefulTopology(storeName),
props);
- final TestInputTopic<String, String> inputTopic =
driver.createInputTopic(INPUT_TOPIC_1, STRING_SERIALIZER, STRING_SERIALIZER);
- final TestOutputTopic<Integer, String> outputTopic1 =
- driver.createOutputTopic(OUTPUT_TOPIC_1,
Serdes.Integer().deserializer(), Serdes.String().deserializer());
-
- inputTopic.pipeInput("key1", "value1");
- inputTopic.pipeInput("key2", "value2");
- inputTopic.pipeInput("key3", "value3");
- inputTopic.pipeInput("key1", "value4");
- assertTrue(outputTopic1.isEmpty());
-
- final KeyValueStore<String, String> store =
driver.getKeyValueStore(storeName);
- assertEquals("value4", store.get("key1"));
- assertEquals("value2", store.get("key2"));
- assertEquals("value3", store.get("key3"));
- assertNull(store.get("key4"));
- }
-
- @Test
- public void testDrivingConnectedStateStoreTopology() {
Review Comment:
as above
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -1776,27 +1229,6 @@ public void process(final Record<String, String> record)
{
}
}
- @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
- private <K, V> org.apache.kafka.streams.processor.ProcessorSupplier<K, V>
define(final org.apache.kafka.streams.processor.Processor<K, V> processor) {
- return () -> processor;
- }
-
- @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
Review Comment:
As above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
