[
https://issues.apache.org/jira/browse/KAFKA-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885573#comment-17885573
]
João Pedro Fonseca commented on KAFKA-14964:
--------------------------------------------
Hi, [~mumrah]! I have just created a PR. In addition to this fix, may I refact
{ClientQuotaMetadataManager#update}. This method has a lot of if statements; I
think we could improve the code readability replacing them with match
statements.
> ClientQuotaMetadataManager should not suppress exceptions
> ---------------------------------------------------------
>
> Key: KAFKA-14964
> URL: https://issues.apache.org/jira/browse/KAFKA-14964
> Project: Kafka
> Issue Type: Bug
> Components: kraft
> Affects Versions: 3.4.0, 3.5.0
> Reporter: David Arthur
> Assignee: João Pedro Fonseca
> Priority: Major
>
> As MetadataLoader calls each MetadataPublisher upon receiving new records
> from the controller, it surrounds the call with a try-catch block in order to
> pass exceptions to a FaultHandler. The FaultHandler used by MetadataLoader is
> essential for us to learn about metadata errors on the broker since it
> increments the metadata loader error JMX metric.
> ClientQuotaMetadataManager is in the update path for ClientQuota metadata
> updates and is capturing exceptions. This means validation errors (like
> invalid quotas) will not be seen by the FaultHandler, and the JMX metric will
> not get incremented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
