mumrah commented on code in PR #17299:
URL: https://github.com/apache/kafka/pull/17299#discussion_r1779170871
##########
.github/actions/gh-api-update-check/action.yml:
##########
@@ -39,23 +39,43 @@ inputs:
description: "The text to display next to the check"
default: ""
required: false
- context:
- description: "The name of the status check"
+ title:
+ description: "The title of the status check"
required: true
- state:
- description: "The state of the check. Can be one of: error, failure,
pending, success"
+ status:
+ description: "The status of the check. Can be one of: queued, in_progress,
completed, waiting, requested, pending"
required: true
+ conclusion:
+ description: "Required if status is 'completed'. Can be one of:
action_required, cancelled, failure, neutral, success, skipped, stale,
timed_out"
+ required: false
runs:
using: "composite"
steps:
- - name: Update Check
+ - if: inputs.conclusion == ''
Review Comment:
The checks API has status and conclusion. The conclusion is only given if
the status is "completed".
If we want to set a check to pending (as we've discussed in other PRs), we
would send status=pending with no conclusion.
Because of the two forms of API call needed (one with conclusion, one
without), we needed two steps with different arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
