junrao commented on code in PR #16443: URL: https://github.com/apache/kafka/pull/16443#discussion_r1778967158
########## clients/src/main/resources/common/message/UpdateFeaturesResponse.json: ########## @@ -17,7 +17,7 @@ "apiKey": 57, "type": "response", "name": "UpdateFeaturesResponse", - "validVersions": "0-1", + "validVersions": "0-2", Review Comment: In V1, if we get a top level error like NOT_CONTROLLER, we don't populate the results array, right? If we fail fast for V1, we could just do the same thing, i.e. set a top level error and don't populate the results array. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
