mumrah commented on code in PR #17284:
URL: https://github.com/apache/kafka/pull/17284#discussion_r1778612897
##########
core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala:
##########
@@ -60,14 +60,16 @@ object SaslApiVersionsRequestTest {
List(ClusterConfig.defaultBuilder
.setSecurityProtocol(securityProtocol)
- .setTypes(Set(Type.ZK).asJava)
+ .setTypes(Set(Type.KRAFT).asJava)
.setSaslServerProperties(saslServerProperties)
.setSaslClientProperties(saslClientProperties)
.setServerProperties(serverProperties)
.build()).asJava
}
}
+// TODO: KAFKA-17631 - Convert SaslApiVersionsRequestTest to kraft
+@Disabled
Review Comment:
Same comment as above
##########
core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala:
##########
@@ -165,7 +166,9 @@ class ClientQuotasRequestTest(cluster: ClusterInstance) {
))
}
- @ClusterTest(types = Array(Type.ZK)) // No SCRAM for Raft yet
+ // TODO: KAFKA-17630 - Convert
ClientQuotasRequestTest#testClientQuotasForScramUsers to kraft
+ @Disabled
Review Comment:
The `@Disabled` annotation takes a String value. Can you put the JIRA ticket
in there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
