chia7712 commented on code in PR #17201:
URL: https://github.com/apache/kafka/pull/17201#discussion_r1773733074
##########
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##########
@@ -324,11 +324,13 @@ public void testDynamicBrokerConfigUpdateUsingKraft()
throws Exception {
@ClusterTest(types = {Type.KRAFT, Type.CO_KRAFT})
public void testGroupConfigUpdateUsingKraft() throws Exception {
- alterOpts = asList("--bootstrap-server", cluster.bootstrapServers(),
"--entity-type", "groups", "--alter");
+ alterOpts =
Stream.concat(entityOp(Optional.of(defaultGroupName)).stream(),
Review Comment:
Can we make alterOpts a local variable? it is a bit chaos that `alterOpts`
can be modified by any method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
