chia7712 commented on code in PR #17202:
URL: https://github.com/apache/kafka/pull/17202#discussion_r1773728581
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultGroupFilter.java:
##########
@@ -73,16 +72,11 @@ static class GroupFilterConfig extends AbstractConfig {
Type.LIST,
GROUPS_EXCLUDE_DEFAULT,
Importance.HIGH,
- GROUPS_EXCLUDE_DOC)
- .define(GROUPS_EXCLUDE_CONFIG_ALIAS,
- Type.LIST,
- null,
- Importance.HIGH,
- "Deprecated. Use " + GROUPS_EXCLUDE_CONFIG + " instead.");
+ GROUPS_EXCLUDE_DOC);
GroupFilterConfig(Map<String, ?> props) {
super(DEF, ConfigUtils.translateDeprecatedConfigs(props, new
String[][]{
Review Comment:
we don't need to call `translateDeprecatedConfigs` now, since the deprecated
configs are removed
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java:
##########
@@ -89,7 +83,7 @@ static class ConfigPropertyFilterConfig extends
AbstractConfig {
ConfigPropertyFilterConfig(Map<String, ?> props) {
super(DEF, ConfigUtils.translateDeprecatedConfigs(props, new
String[][]{
Review Comment:
we don't need to call `translateDeprecatedConfigs` now, since the deprecated
configs are removed
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java:
##########
@@ -81,7 +80,7 @@ public class MirrorCheckpointConfig extends
MirrorConnectorConfig {
public MirrorCheckpointConfig(Map<String, String> props) {
super(CONNECTOR_CONFIG_DEF,
ConfigUtils.translateDeprecatedConfigs(props, new String[][]{
Review Comment:
we don't need to call `translateDeprecatedConfigs` now, since the deprecated
configs are removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
