frankvicky commented on code in PR #17080:
URL: https://github.com/apache/kafka/pull/17080#discussion_r1769459881
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4143,19 +4140,27 @@ public RemoveMembersFromConsumerGroupResult
removeMembersFromConsumerGroup(Strin
String reason = options.reason() == null || options.reason().isEmpty()
?
DEFAULT_LEAVE_GROUP_REASON :
JoinGroupRequest.maybeTruncateReason(options.reason());
- List<MemberIdentity> members;
- if (options.removeAll()) {
- members = getMembersFromGroup(groupId, reason);
- } else {
- members = options.members().stream()
- .map(m -> m.toMemberIdentity().setReason(reason))
- .collect(Collectors.toList());
+ final SimpleAdminApiFuture<CoordinatorKey, Map<MemberIdentity,
Errors>> future =
+ RemoveMembersFromConsumerGroupHandler.newFuture(groupId);
+
+ KafkaFutureImpl<List<MemberIdentity>> f;
+ if (options.removeAll()) f = getMembersFromGroup(groupId, reason);
Review Comment:
nit: I would recommend not omitting the curly braces, or at the very least,
it should break the line.
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4143,19 +4140,27 @@ public RemoveMembersFromConsumerGroupResult
removeMembersFromConsumerGroup(Strin
String reason = options.reason() == null || options.reason().isEmpty()
?
DEFAULT_LEAVE_GROUP_REASON :
JoinGroupRequest.maybeTruncateReason(options.reason());
- List<MemberIdentity> members;
- if (options.removeAll()) {
- members = getMembersFromGroup(groupId, reason);
- } else {
- members = options.members().stream()
- .map(m -> m.toMemberIdentity().setReason(reason))
- .collect(Collectors.toList());
+ final SimpleAdminApiFuture<CoordinatorKey, Map<MemberIdentity,
Errors>> future =
+ RemoveMembersFromConsumerGroupHandler.newFuture(groupId);
+
+ KafkaFutureImpl<List<MemberIdentity>> f;
Review Comment:
Please rename this variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
