mumrah commented on code in PR #17204:
URL: https://github.com/apache/kafka/pull/17204#discussion_r1763226009
##########
.github/workflows/build.yml:
##########
@@ -83,6 +83,14 @@ jobs:
run: python .github/scripts/checkstyle.py
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
+ - name: Update Floating 'cached' Tag on Successful Trunk Build
+ if: github.ref == 'refs/heads/trunk' && success()
+ run: |
+ git fetch --tags
Review Comment:
I think you can fetch a single tag here to save a bit of time.
##########
.github/workflows/build.yml:
##########
@@ -83,6 +83,14 @@ jobs:
run: python .github/scripts/checkstyle.py
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
+ - name: Update Floating 'cached' Tag on Successful Trunk Build
Review Comment:
I like the thorough description, but I think the "on Successful Trunk Build"
qualifier is not needed. In the workflow run UI, we'll see this step skipped in
all cases except on successful trunk builds :)
##########
.github/workflows/build.yml:
##########
@@ -83,6 +83,14 @@ jobs:
run: python .github/scripts/checkstyle.py
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
+ - name: Update Floating 'cached' Tag on Successful Trunk Build
+ if: github.ref == 'refs/heads/trunk' && success()
+ run: |
+ git fetch --tags
+ git tag -f cached $GITHUB_SHA
Review Comment:
When we create the new tag, can we add a message like "Automatically
generated after running workflow 1234.
https://github.com/fonsdant/github-actions/actions/runs/10902593757"; or
similar? This will help us if we need to debug caching issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
